From: Sebastian Keller Date: Fri, 2 Sep 2022 16:37:13 +0000 (+0200) Subject: Revert "signalTracker: Use WeakMap in SignalManager to avoid leaking objects" X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~452^2^2~5 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d57953ad94ef8b58bb37c5d1fc9e6a34f30778ed;p=gnome-shell.git Revert "signalTracker: Use WeakMap in SignalManager to avoid leaking objects" This reverts commit 085102be74f4c98094712a165e5128feaca50438. We need the SignalManager map top be iterable at shutdown for some of the following changes. A WeakMap is not iterable. This revert changes it back to a regular Map, which re-introduces the leaks caused by this. Those will be fixed differently by the two followup commits. Part-of: --- diff --git a/js/misc/signalTracker.js b/js/misc/signalTracker.js index 8444564df..1c3f4f9df 100644 --- a/js/misc/signalTracker.js +++ b/js/misc/signalTracker.js @@ -42,7 +42,7 @@ class SignalManager { } constructor() { - this._signalTrackers = new WeakMap(); + this._signalTrackers = new Map(); } /**